Skip to content

Fixed issues #6 #5 #4 and #2 - #13

Merged
sethetter merged 24 commits into
devict:mainfrom
JustinCockrell1:main
Aug 25, 2024
Merged

sethetter merged 24 commits into
devict:mainfrom
JustinCockrell1:main

Conversation

@JustinCockrell1

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread README.md

@sethetter sethetter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the functionality works great! Thanks for all these additions. Hopefully all the suggestions here are useful, let me know if you have any questions :)

Comment thread lib/slack.ts
Comment thread lib/meetup.ts Outdated
Comment thread lib/meetup.ts Outdated
Comment thread lib/meetup.ts Outdated
Comment thread lib/meetup.ts
Comment thread lib/meetup.ts Outdated
Comment thread commands/question.ts
Comment thread commands/jobs.ts Outdated
Comment thread lib/slack.ts Outdated
Comment thread lib/meetup.ts Outdated
JustinCockrel1 and others added 15 commits August 20, 2024 13:43
@JustinCockrell1

JustinCockrell1 commented Aug 20, 2024 •

Copy link
Copy Markdown
Contributor Author

I think I fixed all the suggestions. Thanks!

Comment thread commands/jobs.ts
channel: event.channel,
text: jobsMessage,
});
respondInThread(event, jobsMessage);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just remove this! Better to keep things clean. We can always refer back to git history.

Comment thread bin/simulate-message.ts
ts: "1723835381.746579",
channel: BOT_TESTING_CHANNEL,
event_ts: "1626252625.000200",
event_ts: "1723832846.938799",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will be the same thread that receives the replies every time this is used now, maybe it would be good to accept as another parameter to the command?

const threadTs = Deno.args[1];, then pass it in with simulate-message.ts "@bot my messsage" 123123123.123123. What do you think?

@sethetter sethetter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to go! Thanks for the contribution, and handling the feedback 😄

@sethetter
sethetter merged commit b5444e9 into devict:main Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants