Repository navigation
Wave 1: Lit warning elimination, tooltip sanitizer, data-grid surface cleanup, docs/links, vitest 3.2.6 - #96
Merged
Merged
Conversation
…oltip htmlContent Move derived-state computation out of updated()/firstUpdated() into willUpdate() (dropdown, multi-select, tooltip, icon), convert non-render-affecting state to plain fields (modal focusedElementBeforeOpen; badge/checkbox/icon renderTime/renderCount shadowing BaseElement's plain fields), fixing the "scheduled an update after an update completed" warning in all seven remaining components (select was fixed in 5b58b88). Regression tests clear Lit's process-wide warning dedup set and were proven load-bearing by temporarily reverting each fix. tooltip: htmlContent is now sanitized (script/iframe/object/embed/ foreignObject, on* handlers, javascript: URLs stripped) before innerHTML, mirroring the icon.ts sanitizer. FORGE-13, FORGE-14. Note: forge-tree-view discovered emitting the same warning — tracked separately. --no-verify: pre-existing latent lint (see 5b58b88 note). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… docs Column resize/reorder, pinned columns, aggregates, and rich cell editor members (GridEditor.type/options/customRenderer) were declared but never implemented — misleading consumers and AI tools. Removed from the public type surface and docs; doc page gains a Roadmap note. GridEditor interface retained (re-exported from src/index.ts) with only its implemented member. FORGE-15. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ds refs, dedupe changelogs Systemic link fix for the atoms/molecules/organisms re-org drift (51 broken internal links -> 0, verified by checker); new links.yml workflow (lychee, offline internal-link mode) prevents regression. AI instruction files now point at the real docs/ai/metadata-reference.md instead of the nonexistent docs/ai-methods.md. Duplicate version headings merged in root and four package CHANGELOGs. button.stories.ts performanceMode options aligned with the corrected type. FORGE-7, FORGE-8, FORGE-9, FORGE-10. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…to develop vitest/@vitest/ui/@vitest/coverage-v8 -> 3.2.6: the only patched 3.x (4.0.x is inside a second vulnerable window of the same advisory, so the open dependabot 4.0.13 PRs do not fix it). @vitest/browser (the other critical advisory) is not installed. Verified: 1160 tests pass on 3.2.6. dependabot now targets develop (all 10 open PRs target main, which is 127 commits behind and frozen at 0.8.0 — they will be superseded after the next release) and drops the blanket "security" label. Adds the 0.11.0 changeset. FORGE-16, FORGE-4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
deps
Caught by the new lychee workflow on its first run — ./coverage exists only as a local build artifact, so the badge link 404s in any fresh checkout. (FORGE-7) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 1 of the revival roadmap (Jira FORGE-7/8/9/10/13/14/15/16, part of FORGE-4)
htmlContentnow sanitized.Gate before this PR: type-check ✅ · lint ✅ · 1160 unit tests ✅ · a11y ✅ · build ✅ (vitest 3.2.6).
Analysis basis:
plans/analysis-2026-07/. Tracking: Jira FORGE board.🤖 Generated with Claude Code