Repository navigation
Conversation
aoyako
marked this pull request as draft
October 10, 2026 12:52
aoyako
marked this pull request as ready for review
October 10, 2026 12:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes Pipenv dependency resolution for all dependency groups.
The issue I am trying to resolve: #16523 - also includes an example of a test repo with issue reproduction.
When the same dependency exists in both
[packages]and[dev-packages], Dependabot parses both requirements, but PipenvRunner currently only uses the first requirement group when running pipenv upgrade.As a result, only one section of Pipfile.lock is updated.
How will you know you've accomplished your goal?
I run Dependabot for my test repo that reproduces the issue:
bin/dry-run.rb pip aoyako/dependabot-test --dep=requestsBefore: only
[packages]are updatedAfter: both
[packages]and[dev-packages]are updatedChecklist
One test is already failing, it is not related to that change.