Repository navigation
Add native windows support. - #238
Open
chinazhangchao wants to merge 1 commit into
Open
chinazhangchao wants to merge 1 commit into
chinazhangchao wants to merge 1 commit into
Conversation
chinazhangchao
marked this pull request as ready for review
October 22, 2026 08:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @interestingLSY , I'm from Microsoft and recently I'm working on improving Windows ARM64 ecosystem support.
So I adds native Windows support for FlashMLA. Could you please help to review? Thanks.
This pull request introduces several important changes to improve Windows CUDA build compatibility, particularly with MSVC, and to enhance cross-platform support in CUDA kernel code. The changes include applying a CUTLASS patch for Windows, introducing MSVC-specific type and assembly handling, and adding compile-time checks for kernel features. These updates ensure that the codebase builds and runs correctly on both Linux and Windows platforms, especially with the MSVC toolchain.
Windows and MSVC compatibility improvements:
README.mdabout automatic application of thecsrc/3rdparty/cutlass-windows.patchduring Windows CUDA builds, detailing requirements and patch origin.cutlass-windows.patchfile, which adds MSVC-specific guards and fixes to CUTLASS headers for Windows CUDA/MSVC builds.int128_ttype asint4for MSVC and adjusted all relevant CUDA kernel code to useint128_tinstead of__int128_t, including MSVC-specific inline assembly for shared memory operations. [1] [2] [3] [4] [5] [6]Cross-platform kernel and build logic:
CUTE_ARCH_TCGEN05_F16F32_MMA_ENABLED) is enabled, providing clearer error messages otherwise. [1] [2] [3] [4] [5] [6] [7] [8]General code improvements:
__builtin_clzwithcute::bit_floorfor better portability in device intrinsics.These changes collectively enhance the portability and reliability of the CUDA codebase for both Windows (MSVC) and Linux environments.