Repository navigation
Conversation
Check the README decoding call against the Python interface without importing torch or the compiled extension. Reject positional arguments from softmax_scale onward, obsolete metadata arguments, and missing test file references, including hyphenated filenames. The current upstream README already corrects the original stale example, so keep it unchanged after rebasing onto 2e5429f.
shoemoney
force-pushed
the
fix/readme-decode-example
branch
from
September 30, 2026 04:45
1b84669 to
d33decb
Compare
shoemoney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stale README decoding call can bind positional flags to the wrong parameters without raising an error. This adds a stdlib-only regression test that parses the README and the Python interface with
ast, checks the decoding call and metadata arguments, and verifies referenced test files exist, including hyphenated filenames.The current upstream README already corrects the example reported here. After rebasing onto
2e5429f, the diff contains only the regression test; the upstream README stays intact.Validation:
python3 tests/test_readme_example.pypasses all three checks. Negative controls fail when positional flags are restored, an obsolete metadata argument is added, or a hyphenated test-file reference is broken.git diff --checkpasses. GPU kernel tests were not run; this change only adds an AST-based documentation test.