You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Multi-file implicit map/array wasm wrappers - where to declare? #138
Currently it's fine when there's only one file they could exist in but this could potentially not be the case.
Some first possibilities are:
declare where the element is declared
declare where it was used
However for maps 2) is problematic as there are potentially two types and for both both 1)/2) are problematic as there could be two different areas using the same type implicitly potentially.
We could potentially either:
Make a priority where it goes something like: try where element(s) declared -> try where used -> lib.rs as fall-back if neither are consistent
Just always put them in lib.rs (can be weird e.g. why is TransactionBodyList in lib.rs when it's only used in block.rs and TransactionBody is in transaction.rs?)
Activity
SebastienGllmt commentedon Feb 8, 2023
we could also put these in a special file just for these imports that have no place to go. Also not great either
docs: ledger the multifile non-root named-table finding (issue #138 c…
docs: scope the multifile finding's catcher as a class — a construct …
test: multifile placement sweep (shape × cross-module ref mode), comp…
docs: ledger the multifile non-root named-table finding (issue #138 c…
docs: scope the multifile finding's catcher as a class — a construct …
test: multifile placement sweep (shape × cross-module ref mode), comp…