Skip to content

[question] NaN check for optimization algorithms? #1607

Open

Description

@Red-Portal

I found out after painful debugging that dlib's find_global_min fails with a segmentation fault when the observed values contain NaN.
What do you think about including a NaN checking procedure to optimization algorithms?
If you like the idea I'll work on it and commit to dlib.

Activity

  1. changed the title [-][request] NaN check for optimization algorithms?[/-] [+][question] NaN check for optimization algorithms?[/+] on Dec 28, 2018
  2. davisking commented on Dec 28, 2018

    @davisking
    Owner

    It certainly shouldn't segfault. So yeah, if you want to submit a PR that makes it throw dlib::error or puts a DLIB_CASSERT on this then that would be a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions