Skip to content

html v2 #7

Closed
Closed

Description

@bukzor

This is a big-ticket to get the revamped html into a usable-by-default state.

This is blocked by four tasks:

@davidmalcolm Could you review this plan and let me know if it needs to be altered and/or what order you'd like to see these four patches? I'll start work after I hear the go-ahead.

Activity

  1. davidmalcolm commented on May 19, 2014

    @davidmalcolm
    Owner

    Looks reasonable; thanks.

    FWIW at some point I want to merge the "firehose" branch (on the fedorahosted site, not mirrored here), which switches the internal datamodel for analysis results to use the data model given at:
    https://github.com/fedora-static-analysis/firehose
    for a clean model vs view separation, and ultimately I want to move the visualization code there, so it can be shared by other analysis tools.

    But don't let that be a blocker to working on this ticket; I can merge it all at a later date.

  2. bukzor commented on May 19, 2014

    @bukzor
    ContributorAuthor

    Is the firehose the same or different than the json consumed by htmlv2?

  3. davidmalcolm commented on May 19, 2014

    @davidmalcolm
    Owner

    It's different. It comes in both XML and JSON serializations, and there's a module of Python objects for working with them. The Firehose branch of cpychecker works by building Firehose Python objects in memory, and I have a port of the old HTML rendering code that works directly on Firehose objects. However, there were enough differecnes in testcase results that I never got around to merging that branch. (I suspect the differences were mostly minor, but it's a substantial job to doublecheck them all. Less work now that the test suite runs in parallel, I guess)

  4. davidmalcolm commented on May 19, 2014

    @davidmalcolm
    Owner

    Also, it would be a new dependency, on firehose. It's in Fedora, and it may be in Debian.

  5. davidmalcolm commented on May 20, 2014

    @davidmalcolm
    Owner

    Note to self: Firehose is in Debian:
    http://packages.qa.debian.org/p/python-firehose.html

  6. bukzor commented on May 20, 2014

    @bukzor
    ContributorAuthor

    all done. yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions