Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an OAuth 2.0 Authorization Server facade and an OAuth-protected MCP proxy to the Apigee deployment, including new JavaScript resources, XML policy definitions, and Terraform configurations. The review feedback highlights several critical improvements: resolving a potential deployment script crash when parsing proxies without JavaScript resources, fixing a logic bug in redirect URI validation, handling CORS preflight (OPTIONS) requests locally to prevent authentication failures, utilizing a cryptographically secure random number generator for CSRF nonces instead of Math.random(), and adding a time allowance to the JWT verification policy to mitigate clock skew issues.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oauthApigee proxy (/api/oauth) implementing OAuth 2.0 authorization code flow with PKCE (S256), JWT bearer (urn:ietf:params:oauth:grant-type:jwt-bearer) streamlined account linking (check,get,create), token refresh,.well-knowndiscovery metadata, and Google Sign-In identity verification./oauth/mcproute that verifies OAuth access tokens, enforces per-user rolling-window quota in Apigee, stripsAuthorizationheaders, and forwards requests to the Mixer ESP endpoint.deploy_apigee.sh,envs/nonprod.yaml,sample.env, andterraform/nonprod/main.tfto bundle JavaScript resources and register theoauthproxy anddatacommons-oauth-stagingproduct indatcom-apigee-dev.