Skip to content

dart-migrate-to-checks-package: negative example has an unmatched quote (triggerSync") #46

Open

Description

@a-urel

In skills/dart-migrate-to-checks-package/SKILL.md, the "NO" example under the synchronous .throws<E>() section is meant to show that passing a callback to a synchronous throws is a compile error. But the snippet is already malformed for an unrelated reason: triggerSync" has a stray double quote, so the line fails to parse before it can demonstrate the callback-type error the prose describes.

https://github.com/dart-lang/skills/blob/26b2dcc/skills/dart-migrate-to-checks-package/SKILL.md#L174

// NO (Passing a callback to sync throws will cause a compiler error!)
check(() => triggerSync").throws<ArgumentError>((it) => ...); // ERROR!

Suggested fix: use the same identifier as the valid example directly above it, so the only thing wrong with the line is the thing the example is about:

check(() => triggerSyncError()).throws<ArgumentError>((it) => ...); // ERROR!

Found while reviewing the skills vendored into a project via npx skills add dart-lang/skills --skill '*' --agent universal (skill hash 00b7fa02… in skills-lock.json).

Activity

  1. Tarika-S commented on Sep 30, 2026

    @Tarika-S

    Hi! I'd like to work on this issue as my next open-source contribution. Could you please confirm that I can take it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions