Skip to content

[tests] Find bash on PATH in the dart:io test scripts - #64553

Closed
pattems wants to merge 1 commit into
dart-lang:mainfrom
pattems:env-bash-test-scripts
Closed

pattems wants to merge 1 commit into
dart-lang:mainfrom
pattems:env-bash-test-scripts

Conversation

@pattems

@pattems pattems commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

tests/standalone/io/dart_std_io_pipe_test.sh and tests/standalone/io/regress_54516_test.sh start with #!/bin/bash, so dart_std_io_pipe_test and regress_54516_test fail on systems where bash isn't installed at /bin/bash, such as NixOS.

This change switches both shebangs to #!/usr/bin/env bash. Systems with /bin/bash behave the same as before.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

@copybara-service

Copy link
Copy Markdown

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/562360

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@copybara-service

Copy link
Copy Markdown

Gerrit CL has been approved, please wait for a reviewer to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant