Skip to content

Run PRESUBMIT.py checks on GitHub PRs #64538

Open

Description

@srawlins

It would be great to require PRESUBMIT.py to run and pass before creating a Gerrit CL.

I guess we'd have to give it a security consideration, but I can't think of any cases where PRESUBMIT.py runs uploaded code. (I guess you'd have to skip PRESUBMIT.py if PRESUBMIT.py or any of its code dependencies is in the PR, lol.)

As it stands, someone uploads a PR, which is immediately converted to a Gerrit CL, and then nothing happens for a while. Then when a Dart engineer takes a look at the code and starts the trybots (because the uploader cannot do that themselves), you might see the most basic issues like code not being formatted.

Alternately, we could add some git-push hooks so that we check code formatting when a developer uploads a GitHub PR. These would hopefully mirror the PRESUBMIT.py checks as closely as possible.

CC @bwilkerson

Activity

  1. added
    area-infrastructureUse area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
    type-enhancementA request for a change that isn't a bug
    on Oct 8, 2026
  2. mraleph commented on Oct 8, 2026

    @mraleph
    Member

    We can also consider closing PRs altogether. I think most of PRs we get are LLM assisted and there no problem for an LLM to figure out how to Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-infrastructureUse area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.type-enhancementA request for a change that isn't a bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions