Repository navigation
Conversation
Uses a WIP version of package:cli_util (dart-lang/tools#2609) which adds SelectOption descriptions and SelectComponentSizing to the select dialogs.
jakemac53
commented
Sep 24, 2026
Keeps DialogSupport non-breaking. EnhancedDialogSupport extends it with methods taking SelectOptions (label + description), and callers fall back to the basic dialogs when it is not implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows each skill's
description(from itsSKILL.mdfrontmatter) as a hover description in theskills getinstall/update selection dialog.Important
This depends on an unpublished version of
package:cli_utilfrom dart-lang/tools#2609 (branchjakemac53/tools:add_multiline_select_descriptions), which addsSelectOption(label, description: ...)andSelectComponentSizing. It is currently wired up via adependency_overridesgit dependency inpkgs/skills/pubspec.yaml, with the hosted constraint set tocli_util: ^0.6.1. The override must be removed (and this PR can land) once that version is published.Changes
SkillFrontmatterparses an optionaldescription;ScannedSkillcarries it (populated by both the package and git scanners,nullfor orphaned skills).DialogSupportis unchanged (non-breaking). A newEnhancedDialogSupport extends DialogSupportaddsshowEnhancedSingleSelectDialog/showEnhancedMultiSelectDialog, which takeSelectOption(label, description: ...)instances (sizing is not exposed). Both are exported frompackage:skills/skills.dart.SelectOptionDialogsextension onDialogSupportuses the enhanced dialogs when available, and otherwise falls back to the basic dialogs with just the labels.CliUtilDialogSupportimplementsEnhancedDialogSupport, maps options tocli_util'sSelectOptions, and usesSelectComponentSizing.fit()instead of the deprecatedmaxVisibleItems/ hand-rolled terminal height computation.Not included
skills removeskill dialog does not show descriptions yet (it only has manifest data, would need to read installedSKILL.mdfiles).