Repository navigation
Conversation
…ows in multiple connection test
There was a problem hiding this comment.
Code Review
This pull request updates the test harness to ensure processes are properly terminated on Windows by polling for the PID, and re-enables a previously skipped test. The review feedback identifies a potential tight loop in the termination logic that could cause high CPU usage and suggests optimizing the PID check by using command-line filters instead of parsing the entire process list.
…enhance cross-platform support Co-authored-by: Copilot <copilot@github.com>
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multi app DTD test on Windows by ensuring orphaned test apps and DTD connections shut down cleanly.
This prevents temp directory cleanup failures when the multi-connection DTD tests run on Windows.
dtd_multiple_connection_test.dartteardown completes properly on WindowsContribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.