Skip to content

Fix #407 - #452

Open
goweii wants to merge 3 commits into
dart-lang:mainfrom
goweii:fix-407
Open

goweii wants to merge 3 commits into
dart-lang:mainfrom
goweii:fix-407

Conversation

@goweii

@goweii goweii commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor

Fix multi app DTD test on Windows by ensuring orphaned test apps and DTD connections shut down cleanly.

This prevents temp directory cleanup failures when the multi-connection DTD tests run on Windows.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test harness to ensure processes are properly terminated on Windows by polling for the PID, and re-enables a previously skipped test. The review feedback identifies a potential tight loop in the termination logic that could cause high CPU usage and suggests optimizing the PID check by using command-line filters instead of parsing the entire process list.

Comment thread pkgs/dart_mcp_server/test/test_harness.dart Outdated
Comment thread pkgs/dart_mcp_server/test/test_harness.dart
…enhance cross-platform support

Co-authored-by: Copilot <copilot@github.com>
@github-actions

Copy link
Copy Markdown

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix multi app DTD test on windows

1 participant