Repository navigation
Conversation
dagger up is renamed to dagger start (dagger/dagger#14218). @start registers through withUp, as @up does, so it needs no engine change. Signed-off-by: Yves Brissaud <yves@dagger.io>
Signed-off-by: Yves Brissaud <yves@dagger.io>
The processor is compiled inside every generated module, so its own use of @up would warn in modules that never use it. Signed-off-by: Yves Brissaud <yves@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@Start, the Java marker for a service function, as part of thedagger up→dagger startrename (dagger/dagger#14218). The engine part is dagger/dagger#14328.This change works on engines that predate
start.@Startregisters the function throughFunction.withUp, the same call@Upmakes. Engines have hadwithUpsince v0.20.4.@Start(io.dagger.module.annotation.Start) marks a function as a service fordagger start.@Upkeeps working. It is@Deprecated, and its Javadoc points at@Start. Modules that use it build as before; javac adds a deprecation note.@Upsuppresses the deprecation warning, because the processor is compiled inside every generated module.e-2-e:service-marker-check, generates a module with a@Startfunction, an@Upfunction, and an unmarked function that returns aService. It loads the module and asserts throughModule.servicesthat only the first two are services.Verification
engine-e-2-e:sdk-contract-check(all 8e-2-e:*checks) andengine-e-2-e:dev-sdk-checkpass at e853f4e. Both run inside an engine built from dagger/dagger 8fd9b22b5416, the commitengine-devis pinned to. That engine hasdagger upand nostart, so the passingservice-marker-checkshows that@Startworks on an engine that predatesstart.@Startbranch removed,service-marker-checkfails witha @Start function should be a service; services: up-marked.Notes
@Startwhendagger generatevendors the new SDK source into it. Until then its vendored copy has only@Up, which keeps working.javaruntime use dagger/daggersdk/java, which gets@Startin Rename dagger up to dagger start dagger#14328.