Skip to content

fix(pstack): route reflect edits out of the plugin cache - #623

Open
jhonnyisaacc wants to merge 1 commit into
cursor:mainfrom
jhonnyisaacc:feat/reflect-route-edits-701b
Open

jhonnyisaacc wants to merge 1 commit into
cursor:mainfrom
jhonnyisaacc:feat/reflect-route-edits-701b

Conversation

@jhonnyisaacc

Copy link
Copy Markdown

Why

/reflect wrote approved skill edits into the installed plugin cache. The next plugin update checked out a new hash and dropped those edits. Apply refuses that cache path and names a destination that survives the update.

What changed

  • Apply never edits a file under the installed plugin cache.
  • A third-party skill edit is a pull request against the repo named by the plugin's repository field. Any other skill is written under the project skills directory or the user skills directory.
  • The summary reports the pull request URL or the destination path.

Scope

  • Covers where an approved reflect edit is written, and that the summary names that place.
  • Leaves review, synthesis, and backlog filing unchanged.
  • Leaves the plugin version unchanged. Merged version bumps are separate pull requests.

Tradeoffs

A project copy of a third-party plugin would keep the edit on one machine and drift from upstream. The edit goes to the plugin source as a pull request instead.

Blast Radius

/reflect no longer changes the installed plugin copy. An approved edit lands in a pull request, or in a project or user skill, so a later plugin update does not drop it.

Verification

  • npm install --no-save ajv ajv-formats && node scripts/validate-plugins.mjs printed All plugins validated successfully.
  • The diff is only the reflect skill. Frontmatter still has name and description, and the referenced reviewer files are present.

Reflect wrote approved skill edits into the installed plugin cache.
A plugin update moved to a new hash and dropped them.

Apply refuses a plugins/cache path.
For a third-party skill, the edit is a PR against the repo named by plugin.json repository.
Apply writes any other skill under .cursor/skills or ~/.cursor/skills.
The summary names the PR URL or the destination path.

Co-authored-by: Jhonny <jhonnyisaacc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants