You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Low-priority follow-ups from 0.1.3 post-release review #12
Logged from the 0.1.3 post-release review (verdict: SHIP; ride these with the next substantive release, not a 0.1.4).
[low] safe_markdown_url() can crash the briefing on malformed URLs
urllib.parse.urlsplit(candidate) in examples/_example_utils.py is not wrapped in try/except. Inputs with unmatched netloc brackets (e.g. https://[bad) raise ValueError per Python docs, which would propagate out of build_output() and kill the run. Fix: return None on parse failure, and check parts.hostname (not just parts.netloc).
[low] YYYY-MM-DD strictness is Python-version dependent
datetime.date.fromisoformat() accepts extra forms (20191240-style compact, ISO week dates) only on Python 3.11+; 3.8–3.10 accept strict YYYY-MM-DD only. Since we support 3.8–3.12, undocumented inputs parse differently per interpreter. If strictness matters, gate with ^\\d{4}-\\d{2}-\\d{2}$ before calling fromisoformat().
[nit] spaces: rejected, not encoded
safe_markdown_url() rejects any whitespace before the .replace(" ", "%20") line runs, so that replacement is unreachable. Behavior is safe either way; align comment/docstring with implementation.
master is not branch-protected (protected: false, no rulesets). "Hygiene" to date = branch deletion discipline, not GitHub enforcement. Setting up protection/rulesets is a repo-admin decision, tracked here for visibility.
Activity