Skip to content

Turn on the new discount engine #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
agoldis wants to merge 2 commits into
base: demo/checkout-triage
Choose a base branch
from
Draft

Turn on the new discount engine #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e0baf
feat: turn on the new discount engine
agoldis Oct 8, 2026
abd6f49
fix: take the discount off once in the new discount engine
agoldis Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion evidence-sharing/checkout-triage/flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{ "newDiscountEngine": false }
{ "newDiscountEngine": true }
2 changes: 1 addition & 1 deletion evidence-sharing/checkout-triage/server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function applyDiscountV1({ code }) {

function applyDiscountV2({ code }) {
const { subtotal, discount, ...applied } = lookupDiscount(code);
const total = (subtotal - discount) - discount;
const total = subtotal - discount;
return { ...applied, discount, total };
}

Expand Down