This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 14, 2020. It is now read-only.
/results page doesn't work #351
Description
It looks like this code didn't get ported over to the new react/flow-router infrastructure.
I see a lot of calls to subscribe:
~/gitting/ccm @kaladin> git grep "subscribe.*roundResults"
both/routes.js: return [subs.subscribe('roundResults',
imports/startup/client/router.jsx: this.register(Meteor.subscribe('roundResults', params.competitionUrlId, params.eventCode, parseInt(params.nthRound)));
imports/startup/client/router.jsx: this.register('roundResults', Meteor.subscribe('roundResults', params.competitionUrlId, params.eventCode, parseInt(params.nthRound)));
imports/startup/client/router.jsx: //<<<this.register('roundResults', Meteor.subscribe('roundResults', params.competitionUrlId, params.eventCode, parseInt(params.nthRound)));
imports/ui/components/resultsList.jsx: Meteor.subscribe('roundResults', props.competitionUrlId, props.eventCode, parseInt(props.nthRound));
imports/ui/pages/competition/competitionResults.jsx: Meteor.subscribe('roundResults', props.competitionUrlId, props.eventCode, parseInt(props.nthRound));
I'm guessing that both/routes.js is going to eventually be deleted? Can it be deleted already?
It looks like some subscription code is happening in the top level router, and other is happening in container components. We should only be doing 1 of those 2 things, right?
Activity
coder13 commentedon Feb 21, 2017
What exactly didn't get ported?