Skip to content

composes duplicates dependancies #58

Closed

Description

@themitchy

If multiple stylesheets are imported (or components importing different stylesheets) and those files compose from a common stylesheet (ie. icons.css) then the styles and composes of the common stylesheet will be duplicated for every import.

This gist shows a simple jsx which imports 2 modules, each of which imports a stylesheet composing from icons.css. Since icons.css composes from font-awesome, all of font-awesome is included in the resulting css twice.

Activity

  1. loklaan commented on Nov 9, 2015

    @loklaan
    Contributor

    Could you try out #57, which should resolve this issue.

  2. themitchy commented on Nov 9, 2015

    @themitchy
    Author

    No dice on #57 - still results in dupes of everything in the common stylesheet.

  3. joshwnj commented on Nov 20, 2015

    @joshwnj
    Member

    @themitchy please take a look at #61 to see whether that fixes the issue.

  4. themitchy commented on Dec 1, 2015

    @themitchy
    Author

    That did it! Thanks @joshwnj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions