Repository navigation
Conversation
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
riasvdv
marked this pull request as draft
October 13, 2026 13:45
Contributor
Author
|
Keeping in draft until some of our largest PRs are merged |
riasvdv
force-pushed
the
chore/phpstan-stricter-level
branch
from
October 15, 2026 12:02
dc939f0 to
3eb3fe8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raise core PHPStan from level 6 to level 7 and resolve the 1,902 reported diagnostics without adding suppressions. Type element queries according to hydrated or array results, correct shared contracts and array shapes, and add inference for collection lists, nullable array entries, and JSON encoding flags.
Move the shared activity timeline payload into a readonly data class while preserving its serialized format. Update adapter contracts to remain compatible with the stricter core types.
Fix defects exposed by the analysis, including numeric previews using XOR instead of exponentiation or passing fractional bounds to
random_int(), and eager-loading maps discarding entries with overlapping numeric keys.