Repository navigation
Harmonize spacing for template headers. - #1278
Conversation
|
Rebased. |
|
This looks good to me. |
|
All checks have failed! How many more checks could one fail? |
|
There's only one check, and it's the check-whitespace check, apparently preventing trailing whitespace. |
|
Let's try again. |
|
I imagine this PR would need some rebasing, but I'm not sure if we want a monolithic commit here. @zygoloid, how would you like to approach this? |
| Predicate pred); | ||
| template <class InputIterator, class OutputIterator1, | ||
| template<class InputIterator, class OutputIterator1, | ||
| class OutputIterator2, class Predicate> |
There was a problem hiding this comment.
This line and those like it need to have their alignment fixed.
There was a problem hiding this comment.
Agreed. I've scriptified the search and found a few pre-existing misalignments, too. Fixed.
|
The difference between one commit per file and one commit in total seems inconsequential to me from a review perspective. I'm fine with letting the change author make that call. |
zygoloid
added
the
needs rebase
|
Rebase? |
|
This needs more than a rebase. I also need to review all the alignments (see @zygoloid's comment). |
Use 'template<class T>'. Also remove space between two closing template brackets.
jensmaurer
removed
the
needs rebase
|
Rebased (in fact, re-done) and misalignments fixed. |
Use
template<class T>.Also remove space between two closing template brackets in [lib].
Leave [temp] unchanged, intentionally showing a variety of styles.
Fixes #53.