Repository navigation
chore: fix clippy warnings - #682
Merged
Merged
Conversation
github-actions
Bot
added
C-cli
|
Bencher Report| Project | cot |
| Branch | fix-clippy |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 12.90 ms(+21.49%)Baseline: 10.62 ms | 18.96 ms (68.01%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.13 ms(+10.73%)Baseline: 1.02 ms | 1.35 ms (83.98%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.04 ms(+8.41%)Baseline: 0.96 ms | 1.25 ms (83.39%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.01 ms(+9.63%)Baseline: 0.92 ms | 1.21 ms (83.66%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 18.92 ms(+12.22%)Baseline: 16.86 ms | 22.04 ms (85.84%) |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are limited to equivalent test assertions and removal of an unnecessary lint expectation.
Review effort: Balanced
Findings: None
What changed in this PR
Updates test assertions to resolve Clippy warnings without changing tested behavior.
Changes:
- Replace emptiness checks with explicit equality assertions.
- Remove an obsolete
clippy::float_cmpexpectation.
| File | Description |
|---|---|
cot/tests/form.rs |
Updates rendered-form assertion. |
cot/tests/db_testing/relations.rs |
Updates cascade result assertion. |
cot/tests/db_testing/query/transactions.rs |
Updates rollback result assertion. |
cot/tests/db_testing/query/order_by.rs |
Updates empty query assertion. |
cot/tests/db_testing/query/like.rs |
Updates pattern-query assertions. |
cot/tests/db_testing/query.rs |
Updates filtering assertion. |
cot/src/openapi.rs |
Updates empty route-parameter assertions. |
cot/src/form/fields/select.rs |
Updates empty field-values assertion. |
cot/src/form/fields.rs |
Removes obsolete lint expectation. |
cot/src/email.rs |
Updates empty recipient-list assertions. |
cot/src/db/fields/chrono_wrapper.rs |
Updates empty weekday assertion. |
cot/src/cli.rs |
Updates empty command-name assertion. |
cot-cli/tests/migration_generator.rs |
Updates migration dependency assertions. |
cot-cli/src/migration_generator.rs |
Updates generated collection assertions. |
cot-cli/src/main.rs |
Updates empty argument assertions. |
cot-cli/src/handlers.rs |
Updates completion-output assertion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.