Repository navigation
chore: update Rust nightly, reformat - #668
Merged
Merged
Conversation
github-actions
Bot
added
C-cli
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are non-functional formatting plus a routine CI nightly pin update, with only a minor comment-grammar nit identified.
Pull request overview
This PR updates the pinned Rust nightly toolchain used in CI and applies formatting-only changes (primarily comment reflow) across the Rust codebase to match updated rustfmt/style output.
Changes:
- Bump CI’s pinned Rust nightly from
nightly-2026-08-28tonightly-2026-09-02. - Reformat/reflow comments across multiple crates/modules without changing runtime behavior.
File summaries
| File | Description |
|---|---|
| cot/tests/db_testing/migrations.rs | Comment reflow only. |
| cot/src/test.rs | Comment reflow only. |
| cot/src/session/store/db.rs | Comment reflow only. |
| cot/src/router.rs | Comment reflow only. |
| cot/src/project.rs | Comment reflow only. |
| cot/src/openapi/swagger_ui.rs | Comment reflow only. |
| cot/src/openapi.rs | Comment reflow only. |
| cot/src/middleware.rs | Comment reflow; exposes an existing small grammar typo. |
| cot/src/form.rs | Comment reflow only. |
| cot/src/db/migrations.rs | Comment reflow only. |
| cot/src/db/impl_mysql.rs | Comment reflow only. |
| cot/src/db.rs | Comment reflow only. |
| cot/src/config.rs | Comment reflow only. |
| cot/src/auth/db.rs | Comment reflow only. |
| cot/src/auth.rs | Comment reflow only. |
| cot-test/tests/doc_code_blocks.rs | Comment reflow only. |
| cot-test/src/lib.rs | Comment reflow only. |
| cot-macros/src/form.rs | Comment reflow only. |
| cot-core/src/error/error_impl.rs | Comment reflow only. |
| cot-core/src/error/backtrace.rs | Comment reflow only. |
| cot-cli/src/utils.rs | Comment reflow only. |
| cot-cli/src/new_project.rs | Comment reflow only. |
| cot-cli/src/migration_generator.rs | Comment reflow only. |
| .github/workflows/rust.yml | Updates pinned nightly toolchain date for CI stability. |
Review details
- Files reviewed: 24/24 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // The inner service may panic until ready, so it's important to clone | ||
| // it here and used the version that is ready. This is a common pattern when | ||
| // using `tower::Service`. | ||
| // it here and used the version that is ready. This is a common pattern |
|
Bencher Report| Project | cot |
| Branch | update-rust |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 14.28 ms(+52.69%)Baseline: 9.35 ms | 17.77 ms (80.33%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.12 ms(+9.04%)Baseline: 1.03 ms | 1.37 ms (82.30%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.05 ms(+8.40%)Baseline: 0.97 ms | 1.26 ms (83.21%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.01 ms(+8.55%)Baseline: 0.93 ms | 1.22 ms (82.68%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17.64 ms(+4.77%)Baseline: 16.84 ms | 21.47 ms (82.17%) |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.