Skip to content

fix(ci): fix coverage failure - #648

Merged
m4tx merged 1 commit into
masterfrom
perhaps-fix-coverage
Aug 29, 2026
Merged

m4tx merged 1 commit into
masterfrom
perhaps-fix-coverage

Conversation

@m4tx

@m4tx m4tx commented Aug 29, 2026 •

Copy link
Copy Markdown
Member

This also:

  • Updates the Rust nightly version
  • Changes the coverage job to depend on check instead of build to avoid a very long wait for it

@github-actions github-actions Bot added the A-ci Area: CI (Continuous Integration) label Aug 29, 2026
@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

🐰 Bencher Report

Projectcot
Branchperhaps-fix-coverage
Testbedgithub-ubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
empty_router/empty_router📈 view plot
🚷 view threshold
14.40 ms
(+61.93%)Baseline: 8.89 ms
16.99 ms
(84.75%)
json_api/json_api📈 view plot
🚷 view threshold
1.14 ms
(+8.94%)Baseline: 1.04 ms
1.36 ms
(83.77%)
nested_routers/nested_routers📈 view plot
🚷 view threshold
1.05 ms
(+7.09%)Baseline: 0.98 ms
1.25 ms
(83.99%)
single_root_route/single_root_route📈 view plot
🚷 view threshold
1.02 ms
(+8.78%)Baseline: 0.94 ms
1.21 ms
(84.70%)
single_root_route_burst/single_root_route_burst📈 view plot
🚷 view threshold
21.43 ms
(+25.47%)Baseline: 17.08 ms
21.54 ms
(99.52%)
🐰 View full continuous benchmarking report in Bencher

@m4tx
m4tx force-pushed the perhaps-fix-coverage branch from aec0110 to d4c1c33 Compare August 29, 2026 12:40
@github-actions github-actions Bot added the C-lib Crate: cot (main library crate) label Aug 29, 2026
@m4tx
m4tx force-pushed the perhaps-fix-coverage branch from d4c1c33 to 4ffaee5 Compare August 29, 2026 14:13
@m4tx
m4tx force-pushed the perhaps-fix-coverage branch from 4ffaee5 to 8d38274 Compare August 29, 2026 14:36
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
rust 90.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m4tx
m4tx marked this pull request as ready for review August 29, 2026 14:53
Copilot AI lite review requested due to automatic review settings August 29, 2026 14:53
@m4tx
m4tx requested a review from a team August 29, 2026 14:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are targeted to CI/test expectations and workflow orchestration, with only a minor security hardening suggestion noted for the newly introduced action pinning.

Pull request overview

This PR addresses a CI coverage failure by updating Rust toolchain expectations and adjusting the coverage workflow to run sooner while keeping nightly pinned to a known-good date.

Changes:

  • Updated UI test stderr snapshots to match current compiler diagnostics.
  • Normalized Rust lint names in Cargo.toml (underscore form).
  • Updated Rust nightly pin and made the coverage job depend on check (plus switched disk cleanup to an action).
File summaries
File Description
cot/tests/ui/unimplemented_form.stderr Updates expected UI test diagnostics output for Form trait error case.
cot/tests/ui/unimplemented_admin_model.stderr Updates expected UI test diagnostics output for AdminModel trait error case.
Cargo.toml Adjusts workspace Rust lint key naming for consistency/compatibility.
.github/workflows/rust.yml Updates nightly pin; coverage job now depends on check; replaces manual disk cleanup with an action.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/rust.yml
@m4tx
m4tx merged commit f47c885 into master Aug 29, 2026
45 checks passed
@m4tx
m4tx deleted the perhaps-fix-coverage branch August 29, 2026 15:03
@cotbot cotbot Bot mentioned this pull request Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI (Continuous Integration) C-lib Crate: cot (main library crate)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants