Repository navigation
fix(ci): fix coverage failure - #648
Merged
Merged
Conversation
|
| Project | cot |
| Branch | perhaps-fix-coverage |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 14.40 ms(+61.93%)Baseline: 8.89 ms | 16.99 ms (84.75%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.14 ms(+8.94%)Baseline: 1.04 ms | 1.36 ms (83.77%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.05 ms(+7.09%)Baseline: 0.98 ms | 1.25 ms (83.99%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.02 ms(+8.78%)Baseline: 0.94 ms | 1.21 ms (84.70%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 21.43 ms(+25.47%)Baseline: 17.08 ms | 21.54 ms (99.52%) |
m4tx
force-pushed
the
perhaps-fix-coverage
branch
from
August 29, 2026 12:40
aec0110 to
d4c1c33
Compare
m4tx
force-pushed
the
perhaps-fix-coverage
branch
from
August 29, 2026 14:13
d4c1c33 to
4ffaee5
Compare
m4tx
force-pushed
the
perhaps-fix-coverage
branch
from
August 29, 2026 14:36
4ffaee5 to
8d38274
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are targeted to CI/test expectations and workflow orchestration, with only a minor security hardening suggestion noted for the newly introduced action pinning.
Pull request overview
This PR addresses a CI coverage failure by updating Rust toolchain expectations and adjusting the coverage workflow to run sooner while keeping nightly pinned to a known-good date.
Changes:
- Updated UI test stderr snapshots to match current compiler diagnostics.
- Normalized Rust lint names in
Cargo.toml(underscore form). - Updated Rust nightly pin and made the coverage job depend on
check(plus switched disk cleanup to an action).
File summaries
| File | Description |
|---|---|
| cot/tests/ui/unimplemented_form.stderr | Updates expected UI test diagnostics output for Form trait error case. |
| cot/tests/ui/unimplemented_admin_model.stderr | Updates expected UI test diagnostics output for AdminModel trait error case. |
| Cargo.toml | Adjusts workspace Rust lint key naming for consistency/compatibility. |
| .github/workflows/rust.yml | Updates nightly pin; coverage job now depends on check; replaces manual disk cleanup with an action. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ElijahAhianyo
approved these changes
Aug 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also:
checkinstead ofbuildto avoid a very long wait for it