Repository navigation
fix(deps): resolve handlebars, qs, traverse and source-map-js Snyk/npm-audit findings (+Claude) - #243
Merged
Conversation
…m-audit findings (+Claude) Bump handlebars, source-map-js, qs (override floor ^6.16.1) and traverse in the lockfile, and retire the ajv/minimatch/brace-expansion overrides that no longer change resolution. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
rohan-agrawal-cs
approved these changes
Oct 15, 2026
SakshiKoli-CS
added a commit
that referenced
this pull request
Oct 15, 2026
development gained #243, which fixes qs and traverse with its own overrides and drops the brace-expansion and eslint/ajv overrides. It conflicted with this branch in package.json's overrides block. Resolved by taking development's overrides as they are and adding only this branch's tty-table csv override (the csv-parse fix). This branch's traverse override and express bump are dropped, because #243 already covers them. package-lock.json is regenerated from development's lockfile. Resolves to cli-utilities and cli-command 2.0.2, csv-parse 7.0.3, qs 6.16.1 and traverse 0.6.14. Build passes, Jest unit tests pass 141/141, integration tests pass 31/31, and Mocha results match the 1.x baseline. snyk test reports only deepmerge. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated Snyk/npm-audit remediation for launch-cli (Node, 1 Snyk project scanned:
package-lock.json).qsoverride floor raised to^6.16.1Ecosystem-native audit (step 1.5)
npm audit: 48 (1 critical, 36 high, 11 moderate) -> 46 (35 high, 11 moderate). Plainnpm audit fixresolved only handlebars and source-map-js, but also re-resolved ~25 unrelated packages (@oclif/core 4.11.14 -> 4.14.0, @contentstack/cli-command/utilities, oclif, ...), and that churn made 30 of 31 integration tests fail ("dynamic import callback was invoked without --experimental-vm-modules"; baseline passes). It was reverted and replaced withnpm update handlebars source-map-js(lockfile diff: those two packages only). The remaining 46 are all behind major-version changes (jest 30, nyc 14, oclif 1.16, shx, lint-staged, cli-utilities 1.9) and are dev-tooling or csv-parse chains; left to Snyk classification, none touched.Retired overrides (step 2.5)
Removed
eslint > ajv,@eslint/eslintrc > ajv,minimatch@10.2.5/9.0.9/5.1.9 > brace-expansionandbrace-expansion@1. With them removed,npm installagainst the existing lockfile leavespackage-lock.jsonbyte-identical, and a fresh no-lockfile resolution lands on ajv 6.15.0 and brace-expansion 1.1.21/2.1.7/5.0.12, all at or above the old floors. Kept:qs,tmp,serialize-javascript,diff(removal reintroduces qs 6.15.3, tmp 0.0.33, serialize-javascript 6.0.2, diff 7.0.0/4.0.4).Needs human review (not resolved)
Notes
.github/workflowschanges (no runtime versions moved)..npmrcinjected by the workspace maps all@contentstack/*to GitHub Packages, but this repo's@contentstack/cli-*deps are public on npmjs; npm was run with--@contentstack:registry=https://registry.npmjs.org(repo file untouched).npm run lintreports 107 pre-existing errors in untouched files.Self code review (step 7.5)
1 round: no High/Medium findings. Lockfile churn beyond the named packages is the
traverse0.6.14 dependency chain (typedarray/which-typed-array patch bumps).Validation
npm install,
npm run build, unit (139 jest) and integration (31) tests pass. Snyk re-scan (--all-projects): handlebars, qs, traverse, source-map-js clear; only the two parked medium findings remain.#claude_code#
🤖 Generated with Claude Code