Repository navigation
Treat .NET 7 required properties as actually required by default #862
Description
Code snippet:
public class Options
{
[Option]
public required int Port { get; init; }
[Option]
public required string Server { get; init; }
}Expected behaviour: Both Port and Server are required and the parsing fails if at least on of them is not present.
Actual behaviour: They are not required, I still have to specify [Option(Required = true)] in order for it to work
Activity
Orace commentedon Dec 12, 2022
Using sharplab.io, it appears that a RequiredMemberAttribute is added to the
requiredproperties.Search for this attribute is a trivia.
Orace commentedon Dec 13, 2022
Has mentioned by DoctorKrolic here
Required = falseis the default case, hence, if we implement this, it will throw on default case.We can make
Required = truemandatory onrequiredproperties, which is redundant and against the purpose of this issue (Treat .NET 7 required properties as actually required by default).We can change the type of the
Requiredattribute property to a try-state (unset,true,false) with anunsetdefault value, which will be treated:truein the case of arequiredpropertyfalsein other casesWe can stay silent and ignore
Required = falseonrequiredproperties.Option 2 looks pretty, but we must validate that it is not a breaking change (see this Jon Skeet post where he talk about the optional parameters). Does a
bool?do the trick?DoctorKrolic commentedon Dec 13, 2022
Uh, I see...
Having
Requiredas abool?can really be a win, so we infernullstate totrueif the property isrequiredandfalseotherwise. I am afraid, this is a binary breaking change though...Orace commentedon Dec 13, 2022
A quick look to the IL shows it unfortunately is 😒