Repository navigation
Dynamic path with GET request #84
Description
Hi all, have a slight conundrum.
Looking at the Hyperclient::Link
https://github.com/codegram/hyperclient/blob/master/lib/hyperclient/link.rb#L84-L91
the _get call on it cannot pass any parameters as params unlike the other options (post, put, and patch)
Where get params are required it cannot be achieved.
Activity
dblock commentedon Mar 18, 2015
The link itself needs to be templated, then it can be constructed with parameters. You're not supposed to throw in random parameters into a get link as far as I understand. That said I would be open for allowing code to do that I think. Want to try a PR and we can discuss it around code?
jufemaiz commentedon Mar 25, 2015
@dblock yep, I get that, however there are times when GET parameters are required - even with a RESTful approach. Will give it a crack. Cheers!
dblock commentedon Aug 15, 2015
@bhoggard this is what we discussed for that sort parameter, give it a shot!
Tests for current behavior, related to codegram#84.
Tests for current behavior, related to codegram#84.
WIP: always expand additional link variables, codegram#84.
WIP: always expand additional link variables, codegram#84.
dblock commentedon Aug 15, 2015
I took a stab at implementing this in #92 and the most efficient solution I found was to patch
URITemplate. There're a few questions:Tests for current behavior, related to codegram#84.
Tests for current behavior, related to codegram#84.
Tests for current behavior, related to codegram#84.
Merge pull request #93 from dblock/tests-for-templated-parameters
WIP: always expand additional link variables, codegram#84.