Repository navigation
fix: use SQLAlchemy session in ta_processor instead of Django ORM - #2572
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
The Sentry GitHub App installation for this repository is missing permissions it needs to keep iterating on this pull request to get CI passing. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: In the
TestResultsProcessorTask,ta_processor()previously queried the database using the Django ORM (ReportSession.objects.using("default").get(...)). Because Django is configured withCONN_MAX_AGE=0in the worker, every query initiates a new database connection directly resolving thepgbouncerhostname. In theworker-test-analyticspod's network namespace, DNS resolution forpgbouncerfails, triggering an unhandledpsycopg2.OperationalError: could not translate host name "pgbouncer" to address: Name or service not known.Fix
db_sessionfromTestResultsProcessorTask.run_implintota_processor().ta_processor(),handle_file_not_found(),handle_parsing_error(), andget_ta_processing_info()from Django ORM models to the worker's native SQLAlchemy models (Upload,UploadError,Repository,Commit).Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-ZAT
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Note
Medium Risk
Touches upload state and error persistence on the test-results path; behavior should match prior Django writes but depends on the injected session being non-null when
update_state=True.Overview
Routes test-analytics upload processing through the worker’s SQLAlchemy session instead of Django ORM, so DB access reuses the task’s pooled connection rather than opening a new Django connection (which was failing DNS for
pgbouncerinworker-test-analytics).TestResultsProcessorTasknow passesdb_sessionintota_processor(). Upload load/update,UploadErrorwrites, and commit/repository lookups use SQLAlchemy models (Upload,UploadError,Commit,Repository) withquery/add/flushinstead ofReportSessionand DjangoobjectsAPIs. Error helpers resolve the session from the upload viaget_db_session()when marking missing files or parse failures.Reviewed by Cursor Bugbot for commit 92bfa82. Bugbot is set up for automated code reviews on this repo. Configure here.