Repository navigation
GHA v4 does not work well when run from workflow_run instead of pull_request #273
Description
### Related issues
- [ ] https://github.com/codecov/codecov-action/issues/1292#issuecomment-1942100350
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
rohan-at-sentry commentedon Feb 13, 2024
@thomasrockhu-codecov can you take a look at this once you're back in?
fix: reset codecov-action back to v3 (#1304)
thomasrockhu-codecov commentedon Feb 21, 2024
Ok, I did a run on a
workflow_runevent and it seems to be working fine. See this run.This leads me to believe there is something else happening. @kdarkhan @adamjstewart @melink14 @JoshuaKGoldberg, if you have any logs or a link that you could point me to, I'd be happy to look in and see why the action@v4 is not working
JoshuaKGoldberg commentedon Feb 21, 2024
Thanks for asking! All of my repos that use the Codecov action should be open source. JoshuaKGoldberg/create-typescript-app#1289 -> JoshuaKGoldberg/create-typescript-app#1303 -> JoshuaKGoldberg/create-typescript-app#1304 should be the main references for that repository in particular. If there's any logstuffs you don't have access to, I'd be happy to provide them.
That repo also is a GitHub repo template you can use to make a new repo to test for yourself. LMK if that's not clear how to use here either 🙂
thomasrockhu-codecov commentedon Feb 23, 2024
@JoshuaKGoldberg
You need to add the token as a secret and as an argument to the
codecov-actionstep from the message on this logadamjstewart commentedon Feb 26, 2024
Uh, from what I can tell, this was triggered by https://github.com/thomasrockhu-codecov/example-python/pull/1, which is not from a fork. Also, the "Download coverage artifacts" step failed to find and download anything. Therefore I would be pretty surprised if the "Upload coverage to codecov" step was doing anything useful. In my testing, I was able to get both of those steps working correctly. The issue I encountered was that
workflow_runnever reported back to the original PR that triggered it, so PRs like torchgeo/torchgeo#1868 never received any coverage information.thomasrockhu-codecov commentedon Feb 27, 2024
@adamjstewart got it, is this specifically in PRs from forks only then?
adamjstewart commentedon Feb 27, 2024
I guess I've never tried a PR from upstream since we don't usually get any out those for open source repos.
thomasrockhu-codecov commentedon Feb 27, 2024
got it, @adamjstewart I'm not sure this is a specific
workflow_runthing, but I'll dig into the logs to see what happened, and why you didn't get a status check or comment. To be clear, I'm going to use this PR as #1868 doesn't seem to have been run at all. Let me know if I misunderstood something.thomasrockhu-codecov commentedon Feb 27, 2024
@adamjstewart I see the problem, the issue was due to rate limiting. Have you installed the Codecov app on your fork?
adamjstewart commentedon Feb 28, 2024
@thomasrockhu-codecov the rate limiting issue was the reason for opening #126. The reason we're using
workflow_runis to try to get around the rate limiting issue. We can't expect all of our contributors to first install the Codecov app in order to get their PRs to pass the tests.thomasrockhu-codecov commentedon Oct 29, 2024
@adamjstewart I'm going to close this as I believe it's been fixed. However, if you feel that isn't true, please feel free to create a new issue and tag me.