# Request I would be nice to have expanded type coverage. ## History - Selenium added typings in 4.1.2 in 2022-02-24 - typeshed: removed selenium types around this time: - https://github.com/python/typeshed/issues/7381 - https://github.com/python/typeshed/pull/8753 - https://github.com/python/typeshed/commit/9b306c33679cdaa8cdc96c9463bceca88634e54b - As of 0.20.1, splinter is partially typed. # Example scenario _Loosely, even if this isn't idiomatic splinter usage, I think the general benefits of annotations and typings still hold. I am fine to elaborate._ Specifically, I am running into any `Any` with [`BaseWebDriver`](https://github.com/cobrateam/splinter/blob/0.20.1/splinter/driver/webdriver/__init__.py#L279)'s attribute [`.driver`](https://github.com/cobrateam/splinter/blob/0.20.1/splinter/driver/webdriver/__init__.py#L280). Where I have a function like: ```python def fill_helper(browser: BaseWebDriver, selectors_path: list[str], value: str) -> None: # ... pass ``` And `mypy` will raise: ``` .../test_website.py:31: error: Argument 1 to "fill_helper" becomes "Any" due to an unfollowed import [no-any-unimported] ``` - Selenium: 4.16.1 - Splinter: 0.20.1 Not relevant, but happen to be using: - pytest: 7.4.3 - pytest-splinter: 3.3.2
Activity
fsouza commentedon Jan 10, 2024
I'm a big +1 on this, but I don't think I'll have time to work on it on the short term. It is something we can make incremental progress though.
Avasam commentedon Aug 25, 2024
Once annotations are complete, I'd lie to request adding a PEP 561
py.typedmarker as well.