Skip to content

More type annotations?  #1222

Open
Open

Description

@tony

Request

I would be nice to have expanded type coverage.

History

Example scenario

Loosely, even if this isn't idiomatic splinter usage, I think the general benefits of annotations and typings still hold. I am fine to elaborate.

Specifically, I am running into any Any with BaseWebDriver's attribute .driver.

Where I have a function like:

def fill_helper(browser: BaseWebDriver, selectors_path: list[str], value: str) -> None:
    # ...
    pass

And mypy will raise:

.../test_website.py:31: error: Argument 1 to "fill_helper" becomes "Any" due to an unfollowed import  [no-any-unimported]
  • Selenium: 4.16.1
  • Splinter: 0.20.1

Not relevant, but happen to be using:

  • pytest: 7.4.3
  • pytest-splinter: 3.3.2

Activity

  1. fsouza commented on Jan 10, 2024

    @fsouza
    Contributor

    I'm a big +1 on this, but I don't think I'll have time to work on it on the short term. It is something we can make incremental progress though.

  2. Avasam commented on Aug 25, 2024

    @Avasam

    Once annotations are complete, I'd lie to request adding a PEP 561 py.typed marker as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions