sgmllib is deprecated #4

Activity

1. smonami commented on Aug 16, 2013

   

   smonami

   on Aug 16, 2013

   More actions

   So in our codebase, sgmllib has been used in web/init.py , feed/feedparser.py and soup/BeautifulSoup.py.
   I believe we just want to remove sgmllib from our web package right?
   Other two are third party packages so not sure.
2. hayd commented on Nov 1, 2014

   

   hayd

   on Nov 1, 2014

   More actions

   I think sgmllib is only used in pattern to create an HtmlParser (in web/__init__.py), python 3 ships with one of these in html.parser (perhaps this can "just work" or needs a small api change) as you say. That is, just keep sgmlib for python 2.

   I ripped out feedparser and soup as deps which makes it easier for pattern going forward in the pattern3 branch (specifically we don't need to care about fixing feedparser/soup with sgmlib, they've already done it).
3. hayd

   added a commit that references this issue on Nov 5, 2014

   Merge pull request clips#4 from hayd/stage1

   ...

   679b569
4. markus-beuckelmann commented on Aug 14, 2017

   

   markus-beuckelmann

   on Aug 14, 2017

   Collaborator

   More actions

   I think sgmllib is only used in pattern to create an HtmlParser (in web/init.py), python 3 ships with one of these in html.parser (perhaps this can "just work" or needs a small api change) as you say.

   For future reference: This is exactly what I ended up doing (see commit da00fff), seems to work fine.
5. markus-beuckelmann

   closed this as completedon Aug 14, 2017