Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b5f04ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
…ep the better token
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ClerkJS waits a limited time for the Device Intelligence result (the Protect session token) before it sends a sign-in or sign-up. A result that arrived after that deadline was discarded. A failed attempt also isn't retried for 30 seconds, so a user who clicked again inside that window sent the request without a result again, even though the token was already in the page. In production, most sign-ups that timed out were sent 10–30 seconds after the script request reached the server, so this is the usual shape of a timeout.
This PR keeps a result that arrives after the deadline and writes it to the shared token store, where the next sign-in or sign-up picks it up. It covers both ways a result can be late:
readypromise settles after the deadline. The late read has no second deadline, so the result is kept however late it arrives.What stays the same:
timeout, and no request waits any longer than before.token_urlmint are unchanged.When a late token is stored, the failure backoff resets, since the attempt did produce a token.
The
clerk.no-rhc.jsbundlewatch limit goes from 322.25KB to 322.5KB; this change lands about 40 bytes over the old one.This is independent of #10275, which raises the default wait to 10 seconds; each helps on its own.
Ref: PROT-1231
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change