Repository navigation
refactor(mosaic): keep the last reverification card in the component, not the controller - #10252
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 61062aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
fbc6378 to
61062aa
Compare
Description
The reverification needs to stay pending during the retry of the action. Previously this was modelled as an explicit settled state, and it didn't reset until the user manually did so, or an action restarted.
This was cumbersome both from an implementation perspective and a public API one. This PR refactors the settled state to live inside of the
<Reverification>component instead.First commit moves the component props to a
<Reverification controller={controller}>shape instead of spreading to prepare for a memo we wanted in the second commit.The important change:
visibleuntil the action is no longer pending. Before, it stayedvisibleuntil reset. If work needs to be done after the API call, like a refresh, there are two options:<Reverification>even after visible goes to falseChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Stack created with GitHub Stacks CLI • Give Feedback 💬