Repository navigation
Preserve nested media table locations while copying datasets - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset.copy()changes table URLs to destination basenames before reading the source MediaTable. A valid dataset withtables/media.csvtherefore fails looking formedia.csvin the source root.Copy local media while the original table URLs are still available. The regression uses the existing media dataset, moves its MediaTable into a subdirectory, and checks copied content after relocation as well as unchanged source content.
The full suite passes on Python 3.12 and 3.9: 205 tests each. This also composes with #202: together they preserve all 64 recorded-data copy configurations, including nested and compressed media tables.