Repository navigation
Allow acyclic SQLite schemas with more than one hundred tables - #90
Merged
Merged
Conversation
xrotwang
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid group with 101 tables currently raises
ValueError: there seem to be cyclic dependencies between the tables, even when no table has a foreign key:The ordering loop removes one eligible table per pass but stops after 100 passes. Continue while tables remain, and stop as cyclic only when a complete pass makes no progress. Add forward/reversed 103-table dependency-chain round trips and a real two-table-cycle check.
Validation: full suites pass on Python 3.12 (842 passed, 16 expected failures) and 3.9 (845 passed, 13 expected failures), with 100% configured coverage; changed source/test Flake8 passes. Published Concepticon list collections of 101 and 113 tables now import successfully in both table orders, with every stored row and cross-list concept frequency matching raw TSV references. Six complete imports at 2/97/100 tables are unchanged. Source on both Python profiles and a fresh installed wheel agree. Four nonrectangular released list files are explicitly excluded without editing their data.