Repository navigation
Honor translated association column names during SQLite reads - #88
Merged
xrotwang merged 2 commits intoOct 28, 2026
Merged
Conversation
xrotwang
approved these changes
Oct 28, 2026
xrotwang
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two parts of the SQLite association reader use untranslated names:
contextcolumn makesDatabase.read()raiseOperationalError: no such column: context.Use the existing translator for
contextin the SQL projection/filter and for the default empty-list keys inTableReadSpec.read_row. This preserves the association schema created by the same translator. Add four regressions covering context renaming and populated/empty lists, asserting the complete output row.Both full suites pass with 100% configured coverage: Python 3.12 has 835 passes/16 expected failures, and 3.9 has 838 passes/13 expected failures. Changed-file Flake8 passes. A separate CSV/SQLite continuation using published Concepticon labels passes all 192 translation configurations after, versus none before, while all 64 complete controls are unchanged. The installed wheel reproduces the fixed source exactly.
This is based directly on current master and is separate from #87's preservation of whitespace in reference values. A local composition of both changes passes the combined suites (839/16 on 3.12, 842/13 on 3.9) and both relational workflows, including multiword values with all columns renamed. The two patches touch the same small reader section and have a local merge conflict; the combined resolution has been validated.