Repository navigation
Fix WiFi ELM initialization deadlock - #1723
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a startup deadlock with some WiFi ELM327 adapters that remain silent until receiving a carriage return.
Problem
DDT4ALL waits for the initial '>' prompt before sending ATZ. Some WiFi ELM adapters do not emit this prompt until they receive '\r', causing initialization to hang indefinitely when the socket is blocking.
Fix
Result
WiFi ELM adapters that previously required manual wake-up (e.g. pressing Enter via netcat) now initialize correctly in DDT4ALL.
Reproduction (before fix)
After fix
Initialization completes without external interaction.
Tested