Repository navigation
Bug: CommandMap prefix ignores override #299
Description
When defining a command_map override, output matches intended functionality:
SSHKit.config.command_map[:rake] = 'pitch_fork'
SSHKit.config.command_map[:rake] => 'pitch_fork'
However, when a prefix for the command exists, the original command is served with the prefix rather than the override:
SSHKit.config.command_map[:rake] = 'pitch_fork'
SSHKit.config.command_map[:rake].push("bundle exec")
SSHKit.config.command_map[:rake] => 'bundle exec rake'
I would figure we'd get this:
SSHKit.config.command_map[:rake] = 'pitch_fork'
SSHKit.config.command_map[:rake].push("bundle exec")
SSHKit.config.command_map[:rake] => `bundle exec pitch_fork`
Should L45 be something like this?:
"#{prefixes} #{@map[command] || command}"
Related source: https://github.com/capistrano/sshkit/blob/master/lib/sshkit/command_map.rb#L42-L45
Activity
dgtized commentedon Dec 1, 2015
👍 I also encountered this. Unfortunately changing the code the way you suggest breaks the existing tests, which suggests that someone may be using the existing defaults logic.
I was trying to use it to swap out rake to always run a command before the generated command. Example:
mattbrictson commentedon Dec 30, 2015
It looks like this issue might be addressed in PR #311.
[-]CommandMap prefix ignores override[/-][+]Bug: CommandMap prefix ignores override[/+]