Repository navigation
fix(memory-pgvector): require lowercase schema and table prefix - #707
Merged
Merged
Conversation
Two follow-ups from #699. memory-pgvector kept its own copy of assertIdentifier, still case-insensitive, while postgres-storage tightened to lowercase. Both interpolate the value into DDL unquoted and Postgres folds an unquoted identifier to lowercase, so `MySchema` created `myschema` and never named the tables the store then queried. The two packages had come to disagree about what a valid identifier is. The copies stay separate, because memory-pgvector depends on @b4run/memory rather than on the agent-state stores and a dependency edge purely to share four lines would drag that package's LangGraph peers in with it; each now carries a comment pointing at the other. The api-reference inventory test allowed 60s for a child analysis that takes ~80s on a laptop, so it failed with ETIMEDOUT while reporting zero analysis failures — red, and saying nothing about the docs. Raised to 180s, sized for a loaded machine rather than close to the observed time. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
blove
enabled auto-merge (squash)
September 17, 2026 18:09
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
blove
temporarily deployed
to
vercel-preview
September 17, 2026 18:20 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from #699, both small and unrelated to each other. Raised together rather than as two near-empty pull requests.
1.
memory-pgvectoridentifier validation#699 tightened
assertIdentifierin@b4run/postgres-storageto reject mixed case.@b4run/memory-pgvectorkept its own near-duplicate copy on the old case-insensitive pattern, so the two Postgres-backed packages disagreed about what a valid identifier is.The reason applies identically to both:
initSchemainterpolatesschemaandprefixinto DDL unquoted, and Postgres folds an unquoted identifier to lowercase. A value likeMySchemacreatedmyschema, so the configured name never named the tables the store then queried.The copies stay separate rather than being shared.
memory-pgvectordepends on@b4run/memory, not on the agent-state stores, and adding a dependency edge purely to share a four-line regex would pull that package's LangGraph peers in with it. Each copy now carries a comment naming the other, so the next person to change one sees the other.Every in-repo caller already passes lowercase (defaults are
public/b4_memory; the test prefixes are base-36, which is always lowercase), so nothing in the repo changes behavior.IDENTIFIER_PATTERNis exported to matchpostgres-storage.This is a behavior change for external callers, described as such in the changeset. It stays a
patch: on this 0.x fixed group a minor bumps every package to 1.0.0.2. API reference inventory test timeout
api-reference-inventory.test.tsspawnedcheck-docs.mjs --analyze-detailed-api-referenceswith a 60 second budget. That analysis re-parses every package's public surface and takes about 80 seconds on a developer laptop, so the test failed withETIMEDOUTwhile the analysis itself reported zero failures. A red test that says nothing about the docs.Raised to 180 seconds, sized for headroom on a loaded machine rather than just above the observed time. A genuine hang still terminates, just later. It passed in CI before this, so this is a latent flake rather than a live break.
Verification
@b4run/memory-pgvectorunit tests, and the gated Testcontainers lane withB4_TEST_PGVECTOR=1: 94 passed, 1 skipped.api-reference-inventory.test.ts, which previously failed on this machine: 252 passed.node scripts/check-docs.mjspasses. TheschemaandtablePrefixoption docs were updated at the source, and the API reference page kept in sync with them, which the contract fingerprint enforces.No release.
🤖 Generated with Claude Code