Repository navigation
feat(cli): opt the vercel target out of vercel.json reconciliation - #697
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ed10c4d to
646c5b1
Compare
GitHub Actions
Inactive
|
The advisory I substituted an independent adversarial review of the diff, and it found a real fail-open in my own change, now fixed in a58f521. The defect. The validator checked only the type of the
Nothing else caught these: the config path applies no runtime schema, and a The fix. Two honesty fixes the review also caught. The opt-out notice claimed the "committed Vercel project settings own buildCommand" — project settings are Dashboard state, not committed, and a prebuilt deploy runs no buildCommand at all. And the opt-out silently retired the Also rebased onto main, which had typed |
GitHub Actions
Inactive
Add `build.vercel.reconcileVercelJson` (default `true`). With it set to `false`, the `vercel` target no longer requires, writes, inspects, or reports an app-root `vercel.json`: a prebuilt flow (`vercel deploy --prebuilt` from CI with no Vercel Git integration) never runs the `buildCommand` that file exists to carry. Fluid compute guidance is unchanged for the deployed project. `b4 check` and `b4 build` share one validator that rejects a non-boolean value with B4_E1003, because the emitter reads the flag with `!== false` and a mistyped `"false"` would otherwise keep reconciliation on silently. Closes #681 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review of the opt-out found that validating only the leaf type let three configs read as configured while the target kept reconciling and writing `vercel.json`: a non-object `build.vercel` (whose optional-chain read yields `undefined`), the flag misplaced directly on `build`, and a case-typo key. The config path applies no runtime schema, and a `b4.config.js` author gets no compiler help, so nothing else caught them. Replace the assertion with `resolveVercelBuildConfig`, which validates the shape and returns the boolean the emitter consumes, so the validated shape and the honored value cannot diverge. Rejects a non-object `vercel`, an unknown key inside it, and the misplaced flag, each with guidance. Also correct the opt-out notice, which claimed the "committed Vercel project settings own buildCommand" — project settings are Dashboard state, not committed, and a prebuilt deploy runs no buildCommand at all. Document that the `fluid: false` build failure is dropped under the opt-out, and that both commands enforce the option, not just `b4 check`. Name the check-side test for what it proves: `b4 check` never reconciled `vercel.json`, so that case is a forward guard, not evidence the opt-out works. The six new validation tests all fail against the previous loose validator. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
a58f521 to
1f72130
Compare
GitHub Actions
Inactive
Adopts #697's build.vercel resolver instead of the parallel one this branch added: - functionName moves into resolveVercelBuildConfig beside reconcileVercelJson, so one resolver validates the whole build.vercel shape and b4 check/b4 build reject a bad name through the path that already rejects a bad flag. The separate check.ts hook is gone. - The emitter reads ctx.buildConfig (#697) rather than the ctx.config field this branch had added, and resolves both options in one call. - types.ts, the config reference, and the CLI page carry both options. - #697's new prebuilt test asserted the old index.func path; updated, plus a test that both options are honored together. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The build target context carries buildConfig from #697, so the config field this branch had added is gone. Spreads skip excess-property checks, so the leftover spread compiled silently. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…cing Two more vercel-target changes landed while this branch was open, and both contradicted the guide: - #697 closed #681 by adding `build.vercel.reconcileVercelJson`. The guide said flatly that there is no opt-out. It now documents the flag, what `b4 build` stops doing when it is off, the four `B4_E1003` near misses that are rejected rather than read as configured, and that Fluid must then be enabled in the project settings because nothing checks it from source. - #699 added `B4_PG_SCHEMA` and `B4_PG_TABLE_PREFIX`. The guide said a generated app requires an app-dedicated database. It now carries the `B4_PG_SCHEMA=$VERCEL_ENV` recipe, which is the Vercel-shaped reason the feature exists, and links to the edge page's table for the rest. cli.mdx conflicted and takes main's `vercel` bullet, which already covers the opt-out, with a link to this page appended. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…721) NATIVE_REMOTE_BUILD_SIGNATURE is consumed as an exact-ordered, all-present signature, and since #697 its last entry, `wrote vercel.json`, is conditional: the vercel target drops the root config from its emitted artifacts when build.vercel.reconcileVercelJson is false, which is the prebuilt-CI configuration. - parseNativeBuildProvenance takes reconcilesVercelJson (default true, matching the target's default) and follows it in both directions: the marker is required when reconciliation is on and must be absent when it is off, since reconciliation that happens anyway means the opt-out never reached the builder - a signature mismatch names the offending marker and how it offended (missing, duplicated, out-of-order, unexpected) instead of reporting only "native Vercel source build provenance is incomplete" - the prebuilt branch still asserts the absence of the full marker list Test-only; no package behaviour changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Closes #681
What
Adds
build.vercel.reconcileVercelJson(defaulttrue) toB4Config. With it set tofalse, theverceltarget no longer requires, writes, inspects, or reports an app-rootvercel.json. A prebuilt flow (vercel deploy --prebuiltfrom CI, no Vercel Git integration) never runs thebuildCommandthat file exists to carry, so the file was only there to satisfy the reconciler.b4 buildprints one stdout notice when the opt-out is active and dropsvercel.jsonfrom the artifact list. Fluid compute guidance is unchanged: the docs still tell the reader to keep it enabled in the Vercel project.Validation
b4 checkandb4 buildshare one validator that rejects a non-boolean value withB4_E1003. The emitter reads the flag with!== false, so a mistyped"false"would otherwise keep reconciliation on while looking configured.One note on the issue text: as written today,
b4 checknever readsvercel.json; the reconciler runs inb4 build, creates the file when missing, warns when an authored file differs, and fails only onfluid: false. The opt-out is wired where the behaviour lives, and the check-side tests guard against a future check-time gate ignoring it.Tests
vercel-target.test.ts: opt-out emits the full Build Output tree with no root or referencevercel.jsonand novercel.jsonin the report; an authored{ "fluid": false }is left unread and untouched under the opt-out;reconcileVercelJson: truekeeps the reconciled contract.build-targets.test.ts: check passes with the opt-out and no committedvercel.json; check and build both reject a non-boolean value withB4_E1003, and build does so before creating.vercel/.Locally: lint, core + cli typecheck,
check-docs, core tests (533), the eight cli test files touched by or timing out in the full run (211, all pass in isolation; the full-suite failures were 5s timeouts under concurrent load), web tests (630 pass;api-reference-inventory's 60s spawn timeout tripped on this loaded machine while the underlying script exits 0 with zero failures in 74s wall / 24s CPU).Docs
docs/cli: newverceltarget bullet covering artifacts, thevercel.jsoncontract, and the prebuilt opt-out.docs/configuration:build.vercel.reconcileVercelJsonin thebuildkey reference; schema-path pin updated inscripts/check-docs.mjs.Changeset: patch for
@b4run/cliand@b4run/core. Not releasing.🤖 Generated with Claude Code