Repository navigation
Conversation
xia-chao
requested review from
cfallin and
rvolosatovs
and removed request for
a team
October 28, 2026 17:26
xia-chao
changed the title
pchickey
requested changes
Oct 29, 2026
pchickey
left a comment
pchickey
left a comment
Contributor
There was a problem hiding this comment.
If we're going to do this we also need to take care of the case where a response is received on the HTTP client which is malformed in this way (in that case, client should return an HttpProtocolError)
xia-chao
changed the title
xia-chao
force-pushed
the
serve-cl-te
branch
3 times, most recently
from
October 30, 2026 12:04
3a53d81 to
caa099a
Compare
Requests and responses carrying both headers are rejected before the guest sees them.
Contributor
Author
|
the duplicate content length tests relied on a TE+CL response, so i changed the fixture |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests and responses that carry both transfer-encoding and content-length are rejected before they reach the guest: 400 for a request and an HttpProtocolError for a response.
Hyper passes both headers through, so a guest was getting a content-length that did not match the body it read.