Repository navigation
fix: lock js-component-bindgen version - #358
Conversation
Pin bindgen to v2.11.0 and require --locked in CI
|
Hey @andreiltd was this break fresh in 2.16.0? In that case I may yank 2.16.0 |
|
Hey @vados-cosmonic it looks like this https://github.com/bytecodealliance/ComponentizeJS/actions/runs/35925632334/job/107399932778?pr=356 PR picked 2.12 and failed the same way. |
|
Welp that's unfortuntate -- sorry for the breakage here, the underlying dep update must have happened a while ago. |
|
Hey @vados-cosmonic. No worries at all! I think another breaking change is in We are passing the absolute |
|
Ah yes, that breaking change was reflected in the versions of |
Newer preview2-shim releases no longer expose the host filesystem by default, preventing the splicer from reading wit paths.
|
I think the changes make sense and it is consistent with p3. I configured splicer to grant access to the wit directory rather than the entire host filesystem. |
Pin bindgen to v2.11.0 and require --locked in CI. This fixes CI failures in other PRs.
Also, adapt to newer preview2-shim releases which no longer expose the host filesystem by default and prevents the splicer from reading wit paths.