Repository navigation
Document summary, title and more are not accessible with input bytes content #194
Description
Actual Behavior
Document.summary() is not working with python3 when the document is based on bytes and not on string content.
Steps to Reproduce the Problem
Follow the readme steps
>>> import requests
>>> from readability import Document
>>> response = requests.get('http://example.com')
>>> doc = Document(response.content)
>>> doc.title()
Traceback (most recent call last):
...
RE_CHARSET.findall(page) + RE_PRAGMA.findall(page) + RE_XML.findall(page)
^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: cannot use a string pattern on a bytes-like objectHow to correct
String Regexp should be updated ro bytes regexp since encoding.get_encoding is only used for bytes content.
In encoding.py :
RE_CHARSET = re.compile(br'<meta.*?charset=["\']*(.+?)["\'>]', flags=re.I)
RE_PRAGMA = re.compile(br'<meta.*?content=["\']*;?charset=(.+?)["\'>]', flags=re.I)
RE_XML = re.compile(br'^<\?xml.*?encoding=["\']*(.+?)["\'>]')
Activity
tomdpsrd commentedon Jul 28, 2025
@buriy to check and merge if it suits you
BruteThought commentedon Jun 11, 2026
Any update on this?
Medno commentedon Jun 24, 2026
@buriy What do you think about this implementation ?
buriy commentedon Jun 25, 2026
Sure let's fix this, bytes weren't supposed to be there but I support all mass wanted features
speedyk-005 commentedon Jul 26, 2026
Same here
buriy commentedon Aug 26, 2026
Fixed in 0.9.
Documentnow accepts response bytes correctly, including the READMErequestsexample, with regression coverage for bytes input and encoding declarations.