Skip to content

build: update HtmlAgilityPack and the test packages - #162

Merged
builtbyproxy merged 3 commits into
mainfrom
dependabot/nuget/LetterboxdSync.Tests/nuget-887061a8ac
Oct 13, 2026
Merged

builtbyproxy merged 3 commits into
mainfrom
dependabot/nuget/LetterboxdSync.Tests/nuget-887061a8ac

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Dependabot's grouped NuGet update, taken over to ship as 2.13.2.

What ships: HtmlAgilityPack 1.6.11 → 1.13.1. The release bundles HtmlAgilityPack.dll with the plugin, so this is a release: version 2.13.2.0, release notes below, and a release-notes.ts entry.

Removed from Dependabot's change: it added direct Microsoft.Extensions.DependencyInjection and Microsoft.Extensions.Hosting.Abstractions 9.0.20 references to the plugin project. Jellyfin provides those assemblies at runtime, so they stay out of the plugin. The plugin builds cleanly without them, and the test project keeps its own references, now at 9.0.20.

Test-only updates, unchanged from Dependabot:

  • coverlet.collector 10.1.0
  • JunitXml.TestLogger 8.0.0
  • NSubstitute 6.2.0
  • Microsoft.NET.Test.Sdk 18.10.1
  • xunit 2.9.3
  • xunit.runner.visualstudio 4.0.1
  • Xunit.SkippableFact 1.5.85

Flaky test fixed (#173): with the new xunit runner, CancelledRun_RecordsNoFailure failed on every run. SyncReliabilityTests and FilmLookupCacheTests each saved LetterboxdSyncRunner.FilmPause as the "default" in a static field. If one class swapped in its no-op pause before the other class first loaded, the second class saved that no-op as its default and restored it on teardown. The cancellation test then ran with no pause and never saw the cancel. The runner now exposes DefaultFilmPause (same 3-5 s delay, no behaviour change), and both classes restore that. Fixes #173.

Verification on 2026-10-13, run locally:

  • Unit suite: 1435/1435, three full runs in a row. Before the fix, it failed four times out of four on these packages.
  • Live suite against letterboxd.com with the CI test account: 17/17 pass with HtmlAgilityPack 1.13.1. That includes the website-path tests that CI skips: sign-in, film lookup from live markup, and rating.

Release notes

Jellyscribe updates the library it uses to read Letterboxd web pages, which it relies on when an account signs in through the website and when it finds films on letterboxd.com. Nothing changes in how syncing works. The website sign-in, film lookups, diary entries and ratings were all checked against letterboxd.com with the new version.

Screenshots

No visible change.

@dependabot dependabot Bot changed the title build: Bump the nuget group with 10 updates build: Bump coverlet.collector and 9 others Oct 13, 2026
@dependabot
dependabot Bot force-pushed the dependabot/nuget/LetterboxdSync.Tests/nuget-887061a8ac branch 3 times, most recently from f4d884a to de63950 Compare October 13, 2026 02:23
Bumps coverlet.collector from 6.0.2 to 10.1.0
Bumps HtmlAgilityPack from 1.6.11 to 1.13.1
Bumps JunitXml.TestLogger from 6.1.0 to 8.0.0
Bumps Microsoft.Extensions.DependencyInjection from 9.0.11 to 9.0.20
Bumps Microsoft.Extensions.Hosting.Abstractions from 9.0.11 to 9.0.20
Bumps Microsoft.NET.Test.Sdk from 17.12.0 to 18.10.1
Bumps NSubstitute from 5.3.0 to 6.2.0
Bumps xunit from 2.9.2 to 2.9.3
Bumps xunit.runner.visualstudio from 2.8.2 to 4.0.1
Bumps Xunit.SkippableFact from 1.5.23 to 1.5.85

---
updated-dependencies:
- dependency-name: coverlet.collector
  dependency-version: 10.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
- dependency-name: HtmlAgilityPack
  dependency-version: 1.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget
- dependency-name: JunitXml.TestLogger
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
- dependency-name: Microsoft.Extensions.DependencyInjection
  dependency-version: 9.0.20
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget
- dependency-name: Microsoft.Extensions.Hosting.Abstractions
  dependency-version: 9.0.20
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.10.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
- dependency-name: NSubstitute
  dependency-version: 6.2.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget
- dependency-name: xunit.runner.visualstudio
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget
- dependency-name: Xunit.SkippableFact
  dependency-version: 1.5.85
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/nuget/LetterboxdSync.Tests/nuget-887061a8ac branch from de63950 to 11f6334 Compare October 13, 2026 02:28
… Microsoft.Extensions packages out of the plugin
@builtbyproxy builtbyproxy changed the title build: Bump coverlet.collector and 9 others build: update HtmlAgilityPack and the test packages Oct 13, 2026
@builtbyproxy
builtbyproxy merged commit 28946c3 into main Oct 13, 2026
8 checks passed
@dependabot
dependabot Bot deleted the dependabot/nuget/LetterboxdSync.Tests/nuget-887061a8ac branch October 13, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: CancelledRun_RecordsNoFailure fails occasionally in the full suite

1 participant