You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@danez I think if the tests pass we should merge it — it's trading off a known bug against a hypothetical bug; this is a fix.
Agree it'd be nice if we could test this ahead of time on dependents, but we don't have the infra setup for that now, and don't think we should hold off merging this patch until then. Hope this makes sense!
Activity
pirosikick commentedon Oct 20, 2017
👍
yoshuawuyts commentedon Oct 20, 2017
PR welcome!
danez commentedon Oct 20, 2017
Without a changelog of static-eval@2 it is rather hard to figure out what the breaking change is and how it affects this module.
yoshuawuyts commentedon Oct 20, 2017
@danez I think if the tests pass we should merge it — it's trading off a known bug against a hypothetical bug; this is a fix.
Agree it'd be nice if we could test this ahead of time on dependents, but we don't have the infra setup for that now, and don't think we should hold off merging this patch until then. Hope this makes sense!
dyaa commentedon Oct 25, 2017
Any updates !
cp4r3z commentedon Oct 26, 2017
Looks like PR #36 might also address the problem, but is more involved. Sounds like @lguzzon has the tests succeeding as well.