Skip to content

Don't require('buffer') #22

Open
Open

Description

@tellnes

The buffer implementation is a lot of code and http-browserify does not really need it to work. It is only needed for auth parameter to bas64 encode it.

Could it be document that the auth parameter is not supported or changed to depend on a base64 library or? Eg. base64-js which buffer-browserify depends on.

Activity

  1. feross commented on Dec 5, 2013

    @feross
    Member

    Where do you see require('buffer')? It looks like buffer is not directly required by http-browserify but rather by stream, which is needed to make the request and response objects be streams. Streams operate on Buffers, so it's required.

  2. tellnes commented on Sep 9, 2014

    @tellnes
    ContributorAuthor

    When I filled this was buffer directly required by http-browserify. Probably did someone resolve it and now, it has been reintroduced by stream.

  3. feross commented on Jul 8, 2015

    @feross
    Member

    This issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions