Skip to content

Can't get example to work #55

Open

Description

@blocka

I'm on ubuntu 14.04 with the latest version of browserify.

I can't get the simple example to work

git clone git@github.com:substack/factor-bundle.git
cd factor-bundle/example/files
mkdir bundle
browserify x.js y.js > bundle.js
browser-unpack < bundle.js | factor-bundle   x.js -o bundle/x.js   y.js -o bundle/y.js   > bundle/common.js

This results in the creation of bundle/common.js but no x.js or y.js

Activity

  1. blocka commented on Feb 1, 2015

    @blocka
    Author

    It seems without adding --full-paths to browserify, the indexes are numeric and thus there's no way (save for providing an rmap, possibly) or matching the input files to the modules.

    I have submitted a pull request to fix the documentation (#56)

  2. terinjokes commented on Feb 1, 2015

    @terinjokes
    Contributor

    factor-bundle is supposed to work with indexes, as it creates a mapping as the files pass through, passing --full-paths shouldn't be needed.

    I'll look when I get a chance.

  3. blocka commented on Feb 1, 2015

    @blocka
    Author

    I don't see anything like that being created. It's not in the bundle.js after I do this:

    cd test/deps
    browserify x.js y.js > bundle.js
    

    If I do browser-unpack < bundle.js there is no mention of x.js or y.js...they've become 2 and 3.

    Interestingly enough, when I call it as a plugin of browserify: browserify x.js y.js -p [ ../../ -o bundle/x.js -o bundle/y.js ] -o bundle/common.js it does work correctly.

    This is great, but it doesn't fit my workflow (I don't know all the js ahead of time, and I'm calling browserify with a glob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions