Repository navigation
Container: fail clearly on an unbound interface or abstract class - #435
Merged
Merged
Conversation
Capsule::resolve() returned the key itself when the class was not instantiable, so make() on an interface or abstract class with no binding handed back the type's *name* as a string. Callers expecting an instance broke far from the cause, most visibly as "Compass::getInjectParameter(): Return value must be of type ?object, string returned" when a controller constructor depended on an interface nobody had bound. resolve() now throws ContainerException::notInstantiable(), whose message names the type, says whether it is an interface or an abstract class, and shows the bind() call to add. Covers make(), makeWith() and dependencies resolved while building another class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capsule::resolve() returned the key itself when the class was not instantiable, so make() on an interface or abstract class with no binding handed back the type's name as a string. Callers expecting an instance broke far from the cause, most visibly as "Compass::getInjectParameter(): Return value must be of type ?object, string returned" when a controller constructor depended on an interface nobody had bound.
resolve() now throws ContainerException::notInstantiable(), whose message names the type, says whether it is an interface or an abstract class, and shows the bind() call to add. Covers make(), makeWith() and dependencies resolved while building another class.