Repository navigation
Pull requests with failing checks are sometimes able to bypass merge rules #283
Description
ci checks in PRs can sometimes be overlooked and this issue could allow for PRs with failing tests to be merged in (#282). This isn't ideal, since at the moment PRs are supposed to pass all ci checks before they can be merged in.
Gotta debug why this can happen at times, and if there's a way to prevent it from happening.
Activity
Loup-Garou911XD commentedon May 21, 2024
That pr was passing ci
Vishyyy338 commentedon May 21, 2024
I think from next time, I should edit the plugman and index.json, create PR, and then edit changelog, so that the CI will show passing clearly for the last commit. Then Rikko will not get confused.
rikkolovescats commentedon Jun 1, 2024
That can't be right.. I remember having to push this commit 88d158d directly to main branch to fix an issue related to updating plugin manager through in-game (as well as to fix the coressponding failing unit test) after the merge of #282.
Vishyyy338 commentedon Jun 1, 2024
Umm... the PR was able to merge because PR's can be accepted with just this condition
Merging can be performed automatically with 1 approving review.. So i think you can change some stuff in settings to add passing CI as a condition too.rikkolovescats commentedon Jun 1, 2024
It already requires both an approval as well as the ci to pass to make PR merge button go green. I'm guessing if the ci doesn't run on the last commit (which for some reason seems to have happened in #282), then it only requires the approval check for the PR merge button to go green.
Loup-Garou911XD commentedon Feb 9, 2025
After the CI commit, checks dont run again
Thats why we can merge because there are no checks that run on CI commits
Loup-Garou911XD commentedon Feb 9, 2025
Loup-Garou911XD commentedon Feb 9, 2025
Loup-Garou911XD commentedon Feb 9, 2025
Notice that the CI doesnt run on CI commits
Loup-Garou911XD commentedon Feb 24, 2025
https://github.com/stefanzweifel/git-auto-commit-action?tab=readme-ov-file#commits-made-by-this-action-do-not-trigger-new-workflow-runs
this might be the issue